-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for upstream] [$2000] Android - Chat - back-to-back bold words don't always render as bold #15648
Comments
Triggered auto assignment to @sonialiap ( |
Bug0 Triage Checklist (Main S/O)
|
@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick! |
1 similar comment
@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Will test tomorrow |
I can reproduce the behavior. On web the text appears 100% bolded, on android it's about 50% bolded |
Triggered auto assignment to @puneetlath ( |
Is this specific to "b" characters only? Or does it apply for any character? And does it only happen if you are at the limit. Or does it happen with any number of back-to-back bolded characters? |
Also, is this an android-only issue? |
Yes, this is Andriod app issue Only |
I tested it with I cannot track down how many iterations of the bolded letter/string cause the bolding to fluctuate. In the screenshot bellow you can see that in the first message (54 words) the bolding falls off after 11 words. But testing with 12 words doesn't affect the bolding, nor does 18 or 24. In a message of 78 words the bolding falls off after 35 words. Sending a message of 54 words again results in the same bolding. So the bolding failure isn't totally random, there is some logic to it. I also tested with a paragraph of lorem ipsum. When I bold the entire paragraph as one (not each individual character/word) then the entire paragraph is correctly bolded. |
Very strange. Ok let's mark it external and see what contributors are able to dig up! |
Job added to Upwork: https://www.upwork.com/jobs/~0199575fa523903823 |
Current assignees @puneetlath and @sonialiap are eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new. |
@cubuspl42 any luck with the review? |
@puneetlath The review is taking longer than I hoped. No word from Facebook's side since my last bump. I bumped the thread again, but I suggest switching to plan B.
What do you think? This way we could unblock our issue, leaving the long-term upstream review asynchronous. |
Looks like he's engaging again, so let's wait a bit more before opening the PR on our fork. |
@puneetlath A more general solution could be a potential next step that the React Native team can consider. I hope that this will speed up the process. |
Ok cool, sounds good! |
android-fix-bold-1.mp4What should be the next step? Should we wait for this change to be eventually picked up organically, or should I create a PR to our fork with a cherry-pick? |
@puneetlath, @cubuspl42, @sonialiap, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Nice!! Great job getting that merged upstream! Do you know how RN releases work? When could we expect it in a release? |
@puneetlath The React Native team is focused on releasing 0.72 now, and I don't think this change has any chance of being included, as it reached a Golden Release Candidate stage. I'm trying to figure out whether we can expect this in 0.72.1, or if we need to wait for 0.73. I asked a question on the merged PR. |
I filed a "pick request". According to this response, a realistic timeline is 0.72.rc6 if rc6 will be needed, or 0.72.1 otherwise. |
Nice! Let's go ahead and get you paid out @cubuspl42 |
@cubuspl42 I've sent you a contract. @sonialiap can you please pay it out once @cubuspl42 accepts? @thesahindia I didn't send you one since I don't think you were involved. Please let us know if I'm mistaken in that. Really great job with this one! |
Also @sonialiap let's keep this open until we've confirmed that it has been incorporated in RN upstream. |
Correct! No compensation for me. |
@sonialiap I've gone ahead and paid this. So we just need to keep it open to track that the upstream PR gets incorporated. I'll just leave it assigned to me for that. |
@puneetlath, @cubuspl42, @thesahindia, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
@puneetlath, @cubuspl42, @thesahindia, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
We're still waiting for the upstream fix to be incorporated. |
@puneetlath, @cubuspl42, @thesahindia, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
The fix should land in React Native 0.73 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #15501
Action Performed:
Precondition:
Use the following sequence of b characters for completing each test:
Expected Result:
All 100% of b characters formatted in bold
Actual Result:
50% of b characters formatted in bold
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.78.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20230303_125606_New.Expensify.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: