-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android #19605
Comments
Triggered auto assignment to @lschurr ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @cristipaval ( |
@cristipaval - does this need to go through the typical Bug Zero process? Should I be testing and adding External or is this an Internal fix? |
Hmm.. it looks like this is a deploy blocker. Let me triage this one. |
This also happens in production 1.3.17-5 |
Job added to Upwork: https://www.upwork.com/jobs/~014c149c7f2dfb4aae |
Current assignee @lschurr is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Current assignee @cristipaval is eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Editing just emoji on a chat cuts the top part on android What is the root cause of that problem?Its happening because space between message and edited text. App/src/pages/home/report/ReportActionItemFragment.js Lines 126 to 131 in fe67d69
We are not providing fontSize or lineHeight to it. so its uses default variables.fontSizeNormalHeight depends on metrics. if its smaller than styles.onlyEmojisText then we can see kind of behavior.
What changes do you think we should make in order to solve the problem?We have 2 ways to fix it. first is we can provide same fontSize as its parent:
<Text
fontSize={variables.fontSizeSmall} <-- add this
selectable={false}
...
>
{' '}
</Text>
IMO, 2nd option is good it will keep same spacing between edited and message. ScreenshotWhat alternative solutions did you explore? (Optional)None |
ProposalPlease re-state the problem that we are trying to solve in this issue.Editing just emoji on a chat cuts the top part on android What is the root cause of that problem?Space between App/src/pages/home/report/ReportActionItemFragment.js Lines 126 to 131 in fe67d69
What changes do you think we should make in order to solve the problem?Remove the
What alternative solutions did you explore? (Optional)N/A |
ProposalPlease re-state the problem that we are trying to solve in this issue.Editing just emoji on a chat cuts the top part on android What is the root cause of that problem?The provided space between the emoticon and the edited text
What changes do you think we should make in order to solve the problem?The simple solution is mentioned below, no need to add extra
|
Thanks for the ping @kushu7. @cristipaval will get it checked. No action needed from your end. |
@lschurr heads up for payment it looks like @pubudu-ranasinghe actually reported this issue on 22 May - see https://expensify.slack.com/archives/C049HHMV9SM/p1684775756347189 - which led to the creation of this #20083, which is a dupe of this. Can we please compensate @pubudu-ranasinghe $250 for the bonus here too, as well as @priya-zha as this was our error. Thanks |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@pubudu-ranasinghe @priya-zha @mananjadhav @kushu7 - can you apply for the job in Upwork? https://www.upwork.com/jobs/~014c149c7f2dfb4aae |
@lschurr applied 👍 |
Submitted the proposal. Thanks. |
@lschurr The job leads to me a login page, and then after logging in, it doesn't redirect to the job post. Can you please send an invite? |
Hmm @mananjadhav try logging in first and then click the job link? https://www.upwork.com/jobs/~014c149c7f2dfb4aae Otherwise, can you send me your profile and I'll try inviting you |
@lschurr https://www.upwork.com/freelancers/~01916123f547b928d6 For some reason my session times out every time with Upwork. |
@lschurr Here's are the items from the checklist.
|
@mananjadhav - I sent an invite to the job in Upwork. @pubudu-ranasinghe please apply to the job in Upwork: https://www.upwork.com/jobs/~014c149c7f2dfb4aae |
Applied @lschurr. Thank you! |
Great, just need @pubudu-ranasinghe to accept the offer in Upwork. I'll create a GH for a new regression test today. |
@lschurr this issue is eligible for the timeline bonus. Can you please help with the same? |
Ah, yep. Let me apply those bonuses. |
Done! |
Thanks @lschurr for the prompt action! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
The top part of emoji should not be cut off on editing the emoji message
Actual Result:
The top part of the emoji is cut off on editing the emoji message
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.18-1
Reproducible in staging?: y
**Reproducible in production?:**n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
emoji.mp4
az_recorder_20230525_080215.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685014708492129
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: