Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validity to game_info message #858

Open
Askaholic opened this issue Nov 18, 2021 · 0 comments · May be fixed by #900
Open

Add validity to game_info message #858

Askaholic opened this issue Nov 18, 2021 · 0 comments · May be fixed by #900

Comments

@Askaholic
Copy link
Collaborator

It would be nice if people could see that a game will be unrated because of certain lobby settings during the lobby phase. Obviously we can’t predict if there will be desyncs or disconnects, but if the game is modded or a bad map is selected we could certainly show it as unrated.

We should add a field validity to the game_info message that will contain certain validity strings (we would probably have to figure out some better names since the naming of the enum is currently pretty inconsistent).

Adding this would require some reworking of when the validity is calculated as it’s currently only computed once when the game is launched. We would probably want to break a certain subset of those validity checks out into checks that are recomputed whenever the game_info message is requested. Those pre-launch validity checks should not make writes to the database since they aren’t final yet, so some of the code will have to be refactored.

Examples of validity states that should always be checked:

  • bad map
  • bad mod
  • wrong victory condition
  • has AI

These validity states could only be checked when the game is full as they may fail and pass again as players join:

  • uneven teams
  • single player
@Askaholic Askaholic linked a pull request Apr 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant