Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection is closed if two login messages are sent to the same connection #968

Open
Askaholic opened this issue May 21, 2023 · 0 comments
Labels

Comments

@Askaholic
Copy link
Collaborator

The logic for detecting that you are already signed in will send a kick message even if the second login request is coming from the exact same connection as the first. I'm not sure if this is really desired. I could see a few potential ways of handling this.

  1. Continue as normal, recreate the player object and resend all of the *_info messages.
  2. Continue as normal, but update the existing player object with the new username rather than recreating the object.
  3. Ignore the request and do nothing
@Askaholic Askaholic added the bug label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant