Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit filenames to 255 bytes #1

Open
Forty-Bot opened this issue Jul 21, 2017 · 0 comments
Open

Limit filenames to 255 bytes #1

Forty-Bot opened this issue Jul 21, 2017 · 0 comments
Labels

Comments

@Forty-Bot
Copy link
Owner

At the moment, we must support filenames of up to 4068 bytes. In addition to not being supported by either Linux or any other major OS, excessively long filenames are both unneccessary and unweildy.

To implement this, the type of lean_dir_entry.name_length would be changed to a uint8_t, and LEAN_DIR_NAME_MAX would be redefined to be 255.

 struct lean_dir_entry {                                                          
        le64 inode;                                                              
        uint8_t type;
        uint8_t entry_length;
        uint8_t name_length;   
        uint8_t name[5];
} __packed;                                                                      
                                                                                 
#define LEAN_DIR_NAME_MAX 255
@Forty-Bot Forty-Bot added the RFC label Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant