-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to customize the FA icon class #54
Comments
I guess I'm confused. If the icon setting were stored in the Granted, I'm not overly familiar (yet) with the Flarum architecture, but aren't all of these settings loaded up front (and/or cached)? Or are you saying every extension has to make a separate query just to retrieve their settings on each request? That would seem strange to me from a design perspective. |
Yes my performance observation is based on the fact that in Flarum, by default, every setting is retrieved with a separate database request. This should be optimized at the Flarum level at some point 😅 |
😮 😨 |
Yeah, I just took a quick look. While I haven't tested this, it would appear that |
Currently, I use FontAwesome Pro's duotone icons (class
fad
). Unfortunately, the icon classes used in this extension (fad fa-address-book
) are currently hardcoded invendor/fof/user-directory/js/src/forum/index.js
. Would love the ability to customize this the way other extensions do.Just a suggestion. Thanks!
The text was updated successfully, but these errors were encountered: