Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Pausing the game can sometimes cause the camera to continue moving. #3096

Open
2 tasks done
AbnormalPoof opened this issue Aug 8, 2024 · 1 comment · May be fixed by #3098
Open
2 tasks done

Bug Report: Pausing the game can sometimes cause the camera to continue moving. #3096

AbnormalPoof opened this issue Aug 8, 2024 · 1 comment · May be fixed by #3098
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.

Comments

@AbnormalPoof
Copy link

AbnormalPoof commented Aug 8, 2024

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - MacOS + Newgrounds (Web)

If you are playing on a browser, which one are you using?

None

Version

0.4.1

Context (Provide images, videos, etc.)

In any song, pausing the game just as the camera begins focusing on something can cause the camera to continue moving, despite the game being paused.

I'd like to mention that this bug is precise! It took me a couple attempts to even record it.

Desktop:

pause.screen.bug.mp4

Web:

pause.screen.bug.web.mp4

Steps to reproduce (or crash logs, errors, etc.)

No response

@AbnormalPoof AbnormalPoof added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Aug 8, 2024
@lemz1
Copy link
Contributor

lemz1 commented Aug 8, 2024

I believe this is happening, because when you open the PauseSubstate the PlayState pauses all tweens. However the camera events are handled after opening a substate, meaning that if you pause at the exact frame a camera event happens, then that camera event doesn't get paused.

With an early return or an if check we could probably prevent this from happening.

@lemz1 lemz1 linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants