-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approval for main Awesome list #91
Comments
@lime360 as the submitter of the PR on Awesome's side. |
nice work !!! |
thx |
it's been 30 days from the first commit |
@BombasticTom Yep! With that, looks like all linting checks currently pass on the main branch. |
@EliteMasterEric I made |
There is a GitHub Action on this repo that adds a build action, which performs style checking using a library built by the creators of the Awesome list. There should be an option that disallows merging pull requests with build failures on them. So if the person's PR has style issues that need to be fixed we can't merge it by mistake. EDIT the option is called Require status checks to pass before merging So if the status of the PR is failure you can't merge it |
pinning this till we get it done |
for people who don't know: I am the one who suggested this to be on main awesome list |
nice |
@lime360 please address this comment: https://github.com/sindresorhus/awesome/pull/2503/files#r1123587843 |
It appears that Lime360 has deleted their account. TODO: Submit a new request for approval on the Awesome list. |
are the last 2 things resolved? |
See linked issue: sindresorhus/awesome#2503
Various small issues block the actual addition of this list to the main directory of resources. Those will be listed here and checked off as they are resolved:
awesome-lint
.The text was updated successfully, but these errors were encountered: