-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request]: Better toolbar view integration for composition dialog #547
Comments
Perhaps we should be aiming straight for the new design by Tobias? |
For now, I agree that removing the view class from the text view looks the best 👍 |
Won't go forward with this for now. There's a spacial case on the narrowest size that puts it on top due to the OSK & other issues with Phosh(? Mobile?) that prevent the dropdowns from poping up (#284, #65)
Looks good so far! There are some cases the mockups don't take into account yet so it's probably best to wait:
(too early to answer them all probably but they are open) I think we will probably follow elk.zone behavior wise 🤷 |
I was thinking everything'd scroll together. This is also something that ScrolledBin would be useful for, so maybe I should complete it. So we'd have
Though it's not visible in the screenshot above, I have it as another top bar in the ToolbarView there. It #NeedsDesign though, @bertob please help us 😄
I don't think I understand what you mean by these, please elaborate? |
Continuing this issue on #553 |
Describe the request
The post composition dialog currently looks like this:
There is a slight difference in color between the header bar and the content view, which looks bad. This can be solved in one of two ways:
.view
) to make it integrate seamlessly with the content. We should try this first as far as I'm concerned.In addition to this, the bottom toolbar should be added as a bottom child to the toolbar view, to make it integrate better with the content as well.
Implementation Details
The text was updated successfully, but these errors were encountered: