Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: full width images #655

Open
1 task done
afranke opened this issue Nov 21, 2023 · 8 comments
Open
1 task done

[Request]: full width images #655

afranke opened this issue Nov 21, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@afranke
Copy link

afranke commented Nov 21, 2023

Describe the request

Images are cropped by default and there is an option to display them within a fixed size letterbox. The Mastodon Web UI used to crop by default and had an option where it doesn’t crop the image and displays it fully like the letterbox option, but instead of fitting the image into a fixed size, it fits the available width and takes as much height as necessary (with no grey above and below either if the image is not tall). That latter fit-width display mode has now become the default and the option has been removed.

Here is how it looks:

image

Implementation Details

@afranke afranke added the enhancement New feature or request label Nov 21, 2023
@GeopJr
Copy link
Owner

GeopJr commented Nov 21, 2023

Thanks for the suggestion!
This is sounds like a dup of #180

@GeopJr GeopJr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
@afranke
Copy link
Author

afranke commented Nov 23, 2023

No, they are not the same thing. #180 still says media should be cropped. The whole point here is not to crop.

@GeopJr GeopJr reopened this Nov 23, 2023
@nekohayo
Copy link

I would suggest retitling this "Don't crop images by default" to avoid confusion with #180 which was about tiny images that didn't scale up to fill the width, AFAIU.

Otherwise, related: #576.

@atirut-w
Copy link

Note that this is a somewhat affecting issues, especially when viewing oblong images like screenshots. The more oblong an image is, the more of it is obscured.

@GeopJr
Copy link
Owner

GeopJr commented Jul 12, 2024

There is a letterbox option in settings

@atirut-w
Copy link

It's still not the most ideal. A better solution would be 1. stretching an image out to fit horizontally (with a reasonable limit), otherwise 2. vertically shrink the container if the image can't be stretched horizontally.

@GeopJr
Copy link
Owner

GeopJr commented Jul 12, 2024

I don't have time right now to dive into this, but 1. is not happening, any sort of stretching is bad. 2. this is basically what this issue and #180 (partially) is about.

I suggested the letterbox setting since your comment sounded unaware of it!

@atirut-w
Copy link

I worded it a bit poorly. I meant stretching while preserving aspect ratio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants