Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Python formatting #81

Open
jpgoldberg opened this issue Jul 26, 2024 · 4 comments
Open

Common Python formatting #81

jpgoldberg opened this issue Jul 26, 2024 · 4 comments

Comments

@jpgoldberg
Copy link

I am finding myself in a sea of merge conflicts even when I think I am making a minor change., I suspect that some of this is due to me (tacitly) using a different fill formatting convention and getting loads of whitespace. That is, I am seeing diffs reported where I do not need a difference.

I would like to recommend that we settle on a common python formatting and linting system. Personally, I would prefer using ruff and we create a ruff.toml file for any non-default settings and for settling on a line length. But I will go along with what others prefer, as long as we settle on something.

@tomato42
Copy link
Collaborator

there's already black being used, executed in CI...

also, why you're getting merge conflicts when doing small changes?! are you sure your main branch is up to date?

@GiacomoPope
Copy link
Owner

The good news is that I've done most (all?) the things I want so there will be less change

Maybe we should add a black config file as @tomato42 set the line length to 79 which is non-standard

@GiacomoPope
Copy link
Owner

I'm not sure where we are with this, but I think it can be closed unless you have concerns @jpgoldberg

@tomato42
Copy link
Collaborator

+1 for closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants