-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpaceshipGenerator iteration issue (memory error) #5
Comments
@Reflexbull that's a lot of spaceships per iteration 😅 Thank you for the accurate bug report, this is most likely due to having too many spaceships that are very very large all at once. I will update the application to try and improve memory usage--for now however I would suggest reducing the iterations from 10 to 7 or 5. PS: log files location should be fixed with the next release, sorry for the confusion. |
@gallorob well, go big or go home :D gotta test the app to give you all the info on improvement/bugs etc. :) |
@Reflexbull yes, the symmetry is available in developer mode. This is still being tidied up, and will be fully functional before the end of the user study (end of November), so any issue regarding it will be momentarily ignored. If you want to check it out anyways, add the " Note that you will have to upload a population to start evolving--there are populations in the source code, named Happy evolution! 😄 |
thanks a lot for your help! Until next time :) |
Hi @gallorob, me again😅 Issue type: Choose from [ bug | feature request ] Severity: Suggest one from [low | medium | high (application-breaking) ] Describe the issue To Reproduce Expected behavior Screenshots Desktop (please complete the following information): OS: Windows PS: I'm interested where on my system disk is this all saved? Which folder? I noticed my system disk space went from 103 GB to 77 GB after 2 iterations, I doubt it would go over 77 GB for 3rd one? And when I closed the application, it went back to 103 GB. |
Hi @Reflexbull, this time it's pretty clear that the spaceship is too large and the program could not allocate 7.38GiB of RAM for it, so I'll add a failsafe for this kind of issue as well. I don't think I'll be able to work on this before Monday, so I'll let you know then. Maybe try your luck with setting the iterations to 5? This way maybe it will crash on the 4th or 5th generation instead of the 3rd 😅 Jokes aside, hopefully I can get this fixed soon and you can resume evolving new spaceships! As for the disk space: the executable extracts the relevant files (dlls mainly) in a temporary folder, which is then cleared once the application is closed. The spaceships themselves are not saved on disk during the evolution, unless you explicitly save the population or the MAP-Elites object (possible only in dev mode). Let's keep this issue open for now. |
Thanks @gallorob for fast replies, take your time, for me personally, it's not a rush :) take as much time as you need to perfect it |
Hi @Reflexbull, I pushed fa65e43 which adds some memory savings and should catch memory allocation errors without breaking the application 😅 Can you try stress-testing it again? And, if possible, attach the log file if it crashes again (the log file is generated in the same directory as the executable)? Thank you. Are you able to run from source? If not, I will release these updates in https://github.com/GoodAI/space-engineers-ai-spaceship-generator/releases/tag/internal-testing so you can test it. |
Hello @gallorob ! To be fair, I never used github so I'm not familiar with pushing and pulling, that saying, I'll just click on the link you provided at the bottom :D |
Hi @Reflexbull, I've updated the release (same link as before, https://github.com/GoodAI/space-engineers-ai-spaceship-generator/releases/tag/internal-testing) to include the memory-related changes. Looking forward to your testing, let me know how that goes! PS: you can now also play around with symmetry in user mode 😉 |
Closing this issue for inactivity (>1 month, no additional reports of a similar issue). |
Issue type: Choose from [ bug | feature request ]
Bug
Severity: Suggest one from [low | medium | high (application-breaking) ]
High (Application-Breaking)
-> in terms, the iterations don't work anymore, nothing is happening and it appears I would have to quit the app and reopen it again in order to make new iterations
Describe the issue
A clear and concise description of what the bug is.
I ran 10 iterations of the ships, then I ran 10 more (20 total) and then I ran 10 more, the 3rd time I ran 10 iterations, I got stuck on 8/10 and got errors which I will provide in the screenshots.
To Reproduce
Steps to reproduce the behavior:
Described above.
Expected behavior
A clear and concise description of what you expected to happen.
Well I expected those 10 iterations to finish and give me a new spaceship.
Screenshots
![scr1](https://user-images.githubusercontent.com/87937223/198528913-42f8cf48-3423-40f3-b007-48f282fc7ebd.png)
![scr2](https://user-images.githubusercontent.com/87937223/198528927-6cee1ea8-1ce5-4404-a4b7-c02dc62442a0.png)
If applicable, please add screenshots to help explain your problem, they tremendously help understanding the issue.
**Note -> I don't understand what a memory error is, but I have more than enough RAM, VRAM and SSD/HDD space if that's the case. (RTX 3070, 32 (2x16) GB 3200 MHz ram and C disk SSD with 95 GB space left, E disk HDD with 705 GB space left).
Log file
In case of bugs, please upload the relevant log file (log_{TIMESTAMP}.log) for inspection. The log file does not contain any user information if the user declined the privacy policy or have already completed the user study.
I don't have it? I need more info on where to find it, as I started the .exe from downloads folder, and I have too much stuff there, but under the name "log_{TIMESTAMP}.log" I can't find anything, I looked in temp folder also, nothing there.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
Just to mention, I am sorry if I got something wrong and/or are wasting your time with this issue, but considering the fact that first 20 iterations ran without problem, I think this was worth mentioning?
The text was updated successfully, but these errors were encountered: