Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connections add: Does not support Oracle wallet #1003

Closed
nj1973 opened this issue Sep 26, 2023 · 1 comment · Fixed by #1083
Closed

connections add: Does not support Oracle wallet #1003

nj1973 opened this issue Sep 26, 2023 · 1 comment · Fixed by #1083
Assignees
Labels
priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.

Comments

@nj1973
Copy link
Contributor

nj1973 commented Sep 26, 2023

It is possible to configure DVT to use an Oracle wallet for authentication, but the options supported by data-validation connections add Oracle do not cater for it.

To support a wallet I needed to use the url config option which I cannot supply via the command line.

$ cat ~/.config/google-pso-data-validator/ora_local_wallet.connection.json
{"source_type": "Oracle", "url": "oracle+cx_oracle://@system_xepdb"}

There are two potential ways to support Oracle wallet:

  1. Enhance by documentation. Simply add a section to the Oracle connections documentation (https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/docs/connections.md#oracle) detailing that the user must manually create the json file.
  2. Enhance DVT to support an option for the connection url. It appears we already support it for DB2.

I propose to attempt option 2 above and if it proves problematic then we can fall back on option 1.

@nj1973 nj1973 changed the title [connections add] does not support Oracle wallet connections add: Does not support Oracle wallet Sep 26, 2023
@helensilva14 helensilva14 added type: feature request 'Nice-to-have' improvement, new feature or different behavior or design. priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. labels Oct 3, 2023
@nj1973
Copy link
Contributor Author

nj1973 commented Nov 14, 2023

This issue is related #825

@nj1973 nj1973 self-assigned this Jan 31, 2024
@nj1973 nj1973 linked a pull request Jan 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.
Projects
None yet
2 participants