Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement uniform logging #419

Closed
nehanene15 opened this issue Apr 4, 2022 · 1 comment · Fixed by #543
Closed

Implement uniform logging #419

nehanene15 opened this issue Apr 4, 2022 · 1 comment · Fixed by #543
Labels
good first issue Good issue for new DVT contributors priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: process A process-releated concern. May include testing, release, or the like.

Comments

@nehanene15
Copy link
Collaborator

DVT uses print statements and logging simultaneously. For example, we usually print logs when verbose is enabled, but in some cases we use the python logging.

We should standardize to only use the Python logger and categorize logs by level (DEBUG, INFO, WARNING, etc.)
@nehanene15 nehanene15 added type: process A process-releated concern. May include testing, release, or the like. priority: p1 High priority. Fix may be included in the next release. good first issue Good issue for new DVT contributors labels Apr 4, 2022
@Sync271 Sync271 mentioned this issue Apr 4, 2022
Closed
@nehanene15 nehanene15 added priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) and removed priority: p1 High priority. Fix may be included in the next release. labels Apr 7, 2022
@nehanene15
Copy link
Collaborator Author

Issue #346 is related.

@latika-wadhwa latika-wadhwa mentioned this issue Jul 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new DVT contributors priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: process A process-releated concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
1 participant
@nehanene15