Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependent aliases and JSON CLI input support #616

Closed
nehanene15 opened this issue Oct 19, 2022 · 0 comments · Fixed by #617
Closed

Remove dependent aliases and JSON CLI input support #616

nehanene15 opened this issue Oct 19, 2022 · 0 comments · Fixed by #617
Labels
priority: p1 High priority. Fix may be included in the next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@nehanene15
Copy link
Collaborator

Dependent aliases were originally built to remove columns that were not needed in row validations since unsupported data types (Structs, arrays) would throw errors. Now that we only bring down the columns we need ever since PR #599, we can get rid of dependent aliases.

We also supported JSON CLI inputs a while back (--tbls {source: table, target: table, ...}) that we don't support anymore. We can clean up this code (Example where we always try to decode JSON before parsing the arguments.

@nehanene15 nehanene15 added type: cleanup An internal cleanup or hygiene concern. priority: p1 High priority. Fix may be included in the next release. labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 High priority. Fix may be included in the next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
1 participant