Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find-tables: Default value of 1 makes sense for --score-cutoff option #678

Closed
nj1973 opened this issue Jan 30, 2023 · 0 comments
Closed
Assignees
Labels
good first issue Good issue for new DVT contributors priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: docs

Comments

@nj1973
Copy link
Contributor

nj1973 commented Jan 30, 2023

From find-tables tool documentation (https://github.com/GoogleCloudPlatform/professional-services-data-validator#building-matched-table-lists):
"
Note that our score cutoff default is a 0.8, which was manually tested to be an accurate value. If no matches occur, reduce this value.
"

I believe the expectation from most end users would for table name matching to be case-insensitive but precise regarding the alphanumeric values used.

I think it would make more sense to --score-cutoff default to 1 and let customers reduce the value if they require non-exact matching.

This is low priority.

@nehanene15 nehanene15 added priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: docs labels Jan 30, 2023
@nehanene15 nehanene15 added the good first issue Good issue for new DVT contributors label Feb 9, 2023
@rishabkhawad rishabkhawad self-assigned this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new DVT contributors priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: docs
Projects
None yet
Development

No branches or pull requests

4 participants