Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate schema: --allow-list option prevents some required mappings #683

Closed
nj1973 opened this issue Jan 30, 2023 · 1 comment · Fixed by #710
Closed

validate schema: --allow-list option prevents some required mappings #683

nj1973 opened this issue Jan 30, 2023 · 1 comment · Fixed by #710
Assignees
Labels
priority: p1 High priority. Fix may be included in the next release.

Comments

@nj1973
Copy link
Contributor

nj1973 commented Jan 30, 2023

There is a secondary check in the code behind --allow-list that ensures the base data type is the same in source and target.
It will accept mapping of decimal(10,0) to decimal(8,0) but rejects decimal(10,0) to int64 (bigint). This is rejected because the base data type of decimal is decimal and that is not the same as the base datatype of int64 which is int.

This prevents these useful mappings:

  • date -> timestamp
  • timestamp -> date
  • decimal(?,0) -> int[16/32/64]

We need to understand why these mappings were prevented and, ideally, extend the accepted base types to include those above.

@nehanene15 nehanene15 added the priority: p1 High priority. Fix may be included in the next release. label Jan 30, 2023
@nehanene15
Copy link
Collaborator

Issue #706 is related - timestamp -> timestamp('utc') could not be passed into the allowlist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 High priority. Fix may be included in the next release.
Projects
None yet
3 participants