Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for simpler report output grid #753

Closed
nj1973 opened this issue Feb 28, 2023 · 1 comment
Closed

Option for simpler report output grid #753

nj1973 opened this issue Feb 28, 2023 · 1 comment
Assignees
Labels
good first issue Good issue for new DVT contributors priority: p3 Lowest priority. This can be something deprioritized or not time sensitive.

Comments

@nj1973
Copy link
Contributor

nj1973 commented Feb 28, 2023

By default the reported output of DVT is Tabulate fancy_grid, as seen in the data_validation/result_handlers/text.py code below:

            print(
                result_df.drop(self.cols_filter_list, axis=1).to_markdown(
                    tablefmt="fancy_grid", index=False
                )

This uses complex characters that are not copy/paste friendly and also inserts a grid line between each report row. For a row validation this can add up to a lot of non-essential noise on screen.

An alternative is to use --format=text but then we gain extra columns because self.cols_filter_list columns are not dropped and lose heading underlines.

This is obviously low priority but it would be nice if could control the tablefmt value hardcoded above. Perhaps any value other than text, csv and json could be passed to to_markdown(tablefmt?

@nj1973 nj1973 added good first issue Good issue for new DVT contributors priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. labels Feb 28, 2023
@Raniksingh
Copy link
Contributor

PR #802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new DVT contributors priority: p3 Lowest priority. This can be something deprioritized or not time sensitive.
Projects
None yet
Development

No branches or pull requests

3 participants