Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML validation directories supported in GCS, but not validation files in GCS #972

Closed
sundar-mudupalli-work opened this issue Sep 6, 2023 · 1 comment · Fixed by #977
Closed

YAML validation directories supported in GCS, but not validation files in GCS #972

sundar-mudupalli-work opened this issue Sep 6, 2023 · 1 comment · Fixed by #977
Assignees
@sundar-mudupalli-work
Labels
priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sundar-mudupalli-work
Copy link
Contributor

Hi,

When we have YAML directories in GCS, they are supported - so the command data-validation configs run -cdir gs://mudu-plex-pri-myb/db6rows/public.iowa_27rows works when you have yaml files in that directory.

However specifying data-validation configs run -c gs://mudu-plex-pri-myb/db6rows/public.iowa_27rows/0001.yaml throws the following error

  File "/home/mudupalli/professional-services-data-validator/env/lib/python3.9/site-packages/data_validation/state_manager.py", line 190, in _read_file
    with open(file_path, "r") as f:
FileNotFoundError: [Errno 2] No such file or directory: './gs://mudu-plex-pri-myb/db6rows/public.iowa_27rows/0001.yaml'

This is a bug.

Thanks.

Sundar Mudupalli
Merged
@helensilva14 helensilva14 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) labels Sep 11, 2023
@afleisc
Copy link
Contributor

afleisc commented Sep 28, 2023 •
edited
Loading

+1 This is something we are trying to do for another customer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sundar-mudupalli-work sundar-mudupalli-work

Labels
priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: yaml validation files in gcs GoogleCloudPlatform/professional-services-data-validator
3 participants
@helensilva14 @afleisc @sundar-mudupalli-work