Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate column: Include date columns in scope of wildcard_include_timestamp option #988

Closed
nj1973 opened this issue Sep 13, 2023 · 0 comments · Fixed by #989
Closed

validate column: Include date columns in scope of wildcard_include_timestamp option #988

nj1973 opened this issue Sep 13, 2023 · 0 comments · Fixed by #989
Assignees
@nj1973
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nj1973
Copy link
Contributor

nj1973 commented Sep 13, 2023

Regarding this option:

    if args.wildcard_include_timestamp:
        supported_data_types.extend(["timestamp", "!timestamp"])

We should include Date columns under the same wildcard_include_timestamp option and update any description/documentation. This was part of issue #981 but was missed.
@nj1973 nj1973 self-assigned this Sep 13, 2023
@nj1973 nj1973 linked a pull request Sep 13, 2023 that will close this issue
feat: Include date columns in scope of wildcard_include_timestamp option #989
Merged
@helensilva14 helensilva14 added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nj1973 nj1973

Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@nj1973 @helensilva14