Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split HIT files into Core and lemmas #1855

Open
Alizter opened this issue Feb 14, 2024 · 2 comments
Open

Split HIT files into Core and lemmas #1855

Alizter opened this issue Feb 14, 2024 · 2 comments

Comments

@Alizter
Copy link
Collaborator

Alizter commented Feb 14, 2024

We should split the various HIT files like GraphQuotient, Coeq, Pushout into separate files like we do for Join which will make the compilation faster.

@jdchristensen What about splitting the various HITs into files like we do for Join? That way we can have the core definition and various results like functionality or flattening in separate files? In any case, I would suggest doing the splitting later when we have the flattening lemmas and we can do it all in one go.

Originally posted by @Alizter in #1851 (comment)

@jdchristensen
Copy link
Collaborator

jdchristensen commented Feb 14, 2024

Do you mean creating subdirectories for each type of colimit, like Colimits/GraphQuotient/*, Colimits/Coeq/*, Colimits/Colimit/*, Colimits/Pushout/*, etc? That might be ok, but it might also be overkill, since currently the only thing we separate are the flattening lemmas.

@Alizter
Copy link
Collaborator Author

Alizter commented Feb 14, 2024

@jdchristensen Yes that is what I meant. I'm fine with splitting the flattening lemmas into separate files too. One thing to keep in mind is that the flattening lemams are now much lighter so it might not be as big of an issue as before with the colimits library. I think we will have to see once those PRs are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants