Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Sample Interval is incorrect #1

Open
kurtismash opened this issue Sep 28, 2018 · 2 comments
Open

Sample Interval is incorrect #1

kurtismash opened this issue Sep 28, 2018 · 2 comments
Assignees

Comments

@kurtismash
Copy link
Member

Sampler is not async, therefore the sample interval is the configured time in seconds + time for FFMPEG to run.

@kurtismash kurtismash self-assigned this Sep 28, 2018
@Jamie0
Copy link
Member

Jamie0 commented Sep 29, 2018

Instead of making this async, you could store the timestamp in which the sampler runs, and then at the end sleep(interval + time_since_last_run - now()).

@kurtismash
Copy link
Member Author

Right now this is completed using a java.util.Timer. If the previous sample has yet to return from gnsdk.lookupStream(), the application waits for this to complete before sampling again. Whilst this is not ideal, it does avoid the need to sequence each sample to avoid receiving track information out of order.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants