Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disco suggest gives empty results #19

Open
kofronpi opened this issue Jul 22, 2024 · 7 comments
Open

Disco suggest gives empty results #19

kofronpi opened this issue Jul 22, 2024 · 7 comments

Comments

@kofronpi
Copy link

kofronpi commented Jul 22, 2024

On a clean Ubuntu install from git, after disco import and disco import --tracks && disco import -zz, disco suggest never gives any results.

The matching algorithm seems to be somewhat broken (only 114 tracks from MB, 55 tracks filled with metadata from AB on 304 in my collection), but there is some data :

Processed: 303.
MusicBrainz info added to DiscoBASE: Release MBIDs: 114, Recording MBIDs: 110
AccousticBrainz info added: Key: 55, Chords Key: 55, BPM: 55
No AcousticBrainz entries available yet: 55
Database errors: 0. Not found on Discogs errors: 0. No track number in DiscoBASE errors: 1.
Additional Discogs fetches necessary: 0.

Results of disco suggest:

discodos) pak@***:~/Dev/discodos$ disco suggest -b 123

Showing tracks with a BPM around 123. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 120

Showing tracks with a BPM around 120. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 130

Showing tracks with a BPM around 130. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 100

Showing tracks with a BPM around 100. Pitch range is +/- 6%.

(discodos) pak@***:~/Dev/discodos$ disco suggest -b 140

Showing tracks with a BPM around 140. Pitch range is +/- 6%.

I can't seem to find the debug log file

@JOJ0
Copy link
Owner

JOJ0 commented Jul 23, 2024

Several things:

  • I currently do not maintain DiscoDOS properly
  • I do use it myself though occasionally
  • I rewrote the CLI a couple of months ago, try the new command dsc instead of disco (install from git required!)
  • The docs of the project are very very outdated!!
  • The matching algorithm, actually the fetching data from AB cannot work anymore properly because AcousticBrainz project was discontinued by the metabrainz foundation about 1-2 years ago

Hope that helps!

If tou want to help me fix the docs, a first step would be to remove or mark as outdated the AcousticBrainz related stuff there!

If you find a bug in the cli, I would prefer not to fix the old cli
disco and rather concentrate on dsc. PR's and issues are welcome!

@JOJ0
Copy link
Owner

JOJ0 commented Jul 23, 2024

Since you are on Ubuntu and installed from git AFAIR the log file should be somewhere in

~/.discodos/

@JOJ0
Copy link
Owner

JOJ0 commented Jul 23, 2024

To spit out debug logs directly on the shell you are executing, use global switches. Eg

dsc -vv suggest -b 123

@JOJ0
Copy link
Owner

JOJ0 commented Jul 23, 2024

The matching algorithm seems to be somewhat broken (only 114 tracks from MB, 55 tracks filled with metadata from AB on 304 in my collection), but there is some data :

Yes it probably is! ...and always was....

The matching (which happens before fetching anything from AB) is a very clumsy process that tries to match via artist title catalognumber and tries some variation tricks on cat numbers. It's not very smart though, rather stupid tries different things then gives up. Since data on Discogs and on MB can be very different, if you get 50% of your tracks matched, you are lucky...

The logging is pretty detailed though, try

dsc -vv import -zz

@JOJ0
Copy link
Owner

JOJ0 commented Jul 23, 2024

Some of the project's issues I just mentioned are addressed in this PR I'm about to merge: #20

@JOJ0
Copy link
Owner

JOJ0 commented Jul 27, 2024

Did any of this help @kofronpi ? Or did you give up on DiscoDOS since you heard the bad news about AcousticBrainz gone for good? ;-)

@kofronpi
Copy link
Author

kofronpi commented Aug 2, 2024

@JOJ0 holidays right now, I will try again later :) But I'm not giving up !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants