-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Json instead of Ini #124
Comments
This may be a bad idea. Currently, the configs of the game fit with ini. If we change them to json forcibly, we can get more codes and bigger, complex configurations only. Most configs are not too complex to fit json, except subtitles. But subtitles also takes way more space - the size of |
We can rewrite loading screens then. Just make something similar to achievements system |
Also I think we should return thinking about IniControler for subtitles. Using a lot of dlls isn't a good practice |
The latest subtitle system is too complex to use ini, even And about too many DLLs - I can merge RapidBson into |
These files are that I think it is worth converting to json:
|
|
Here are two solutions:
Both of them are not considering backward compatibility, so they are for future versions only. |
What about |
Obviously it can be converted to. But the complexity of my design made it is not worth to do this. It can and should be replaced by jsonc files, but I don't know how to make this perfectly. |
For designing of ini file, loading_screen.ini is unable to be uploaded to ZiYue Weblate, because we can't modify the section.
We can re-design the architecture of loading_screen.ini, but it's better to use json. I will try to make a json reader to make it.
The text was updated successfully, but these errors were encountered: