-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest tag fails for build ? #29
Comments
so just using latest for now... |
maybe we need a go.work not the root and then a go.mod for each cmd folder ? will make it easier for you ? |
Hi Ged, The This decision was made prior to |
@gedw99 I've pushed a commit that makes use of workspaces. Can you see if this works as expected? Latest tag |
thanks @JackMordaunt The aim is to be able to do a go install for each of the 2 cmd mains. quick test using go install. neither works. go install github.com/jackmordaunt/icns/v2/cmd/[email protected]
go: github.com/jackmordaunt/icns/v2/cmd/[email protected]: github.com/jackmordaunt/icns/v2/cmd/[email protected]: reading https://proxy.golang.org/github.com/jackmordaunt/icns/v2/cmd/icnsify/@v/v2.3.0.info: 404 Not Found
server response: not found: github.com/jackmordaunt/icns/v2/cmd/[email protected]: invalid version: unknown revision v2/cmd/icnsify/v2.3.0
go install github.com/jackmordaunt/icns/cmd/[email protected]
go: github.com/jackmordaunt/icns/cmd/[email protected]: github.com/jackmordaunt/icns/cmd/[email protected]: reading https://proxy.golang.org/github.com/jackmordaunt/icns/cmd/preview/@v/v2.3.0.info: 404 Not Found
server response: not found: github.com/jackmordaunt/icns/cmd/[email protected]: invalid version: unknown revision cmd/preview/v2.3.0
old version is same as before with only icnsify working. go install github.com/jackmordaunt/icns/v2/cmd/[email protected]
go install github.com/jackmordaunt/icns/cmd/[email protected]
go: github.com/jackmordaunt/icns/cmd/[email protected]: github.com/jackmordaunt/icns/cmd/[email protected]: reading https://proxy.golang.org/github.com/jackmordaunt/icns/cmd/preview/@v/v2.2.7.info: 404 Not Found
server response: not found: github.com/jackmordaunt/icns/cmd/[email protected]: invalid version: unknown revision cmd/preview/v2.2.7
latest does work for the gio app # works !!
go install github.com/jackmordaunt/icns/cmd/preview@latest For the Preview command, I guess we need the tagged release to be a zipped ( or tar ) of the packaged binary for the 6 permutations of the 3 OS and the 2 go arch ( amd64 and arm64 ). Will need the CI GitHub action to compile using a matrix and then to do a release on a pushed tag. Then devs can use a curl or whatever to get the zip, unzip it and run the gio app. Thats what I think anyways... If our curious, I am using a refile to do all this on another project. The makefile is called locally and in CI. One source of truth. |
I've made some more structural changes.
I can successfully
@gedw99 Can you please verify this on your end, thanks :) |
hey @JackMordaunt Thanks for this... latest works 👍 go install github.com/jackmordaunt/icns/v2/cmd/icnsify@latest
go install github.com/jackmordaunt/icns/cmd/preview@latest
v3.0.0 does not.... go install github.com/jackmordaunt/icns/v2/cmd/[email protected]
go: github.com/jackmordaunt/icns/v2/cmd/[email protected]: github.com/jackmordaunt/icns/v2/cmd/[email protected]: reading https://proxy.golang.org/github.com/jackmordaunt/icns/v2/cmd/icnsify/@v/v3.0.0.info: 404 Not Found
server response: not found: github.com/jackmordaunt/icns/v2/cmd/[email protected]: invalid version: unknown revision v2/cmd/icnsify/v3.0.0
go install github.com/jackmordaunt/icns/cmd/[email protected]
go: github.com/jackmordaunt/icns/cmd/[email protected]: github.com/jackmordaunt/icns/cmd/[email protected]: reading https://proxy.golang.org/github.com/jackmordaunt/icns/cmd/preview/@v/v3.0.0.info: 404 Not Found
server response: not found: github.com/jackmordaunt/icns/cmd/[email protected]: invalid version: unknown revision cmd/preview/v3.0.0
v2.2.7 only for icnsify go install github.com/jackmordaunt/icns/v2/cmd/[email protected]
go install github.com/jackmordaunt/icns/cmd/[email protected]
go: github.com/jackmordaunt/icns/cmd/[email protected]: github.com/jackmordaunt/icns/cmd/[email protected]: reading https://proxy.golang.org/github.com/jackmordaunt/icns/cmd/preview/@v/v2.2.7.info: 404 Not Found
server response: not found: github.com/jackmordaunt/icns/cmd/[email protected]: invalid version: unknown revision cmd/preview/v2.2.7
Would be nice is there is a tagged release version so that me and others can have a stable version we can use. I use it as part of CI... |
Hey @JackMordaunt
Not sure as I did not dig into this, but v2.2.7 tag works for one cmd but not the other...
The text was updated successfully, but these errors were encountered: