Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test that executes in CI #14

Open
JakeYallop opened this issue May 18, 2024 · 2 comments
Open

Add smoke test that executes in CI #14

JakeYallop opened this issue May 18, 2024 · 2 comments

Comments

@JakeYallop
Copy link
Owner

JakeYallop commented May 18, 2024

Run a smoke test in CI - run the published executable with something like

WaybackDownloader.exe archive.org ./downloads -m exact --limitPages 1 -p SomeString1 -r 1 -v --clearHistory -f statuscode:200 -f mimetype:text/html --from 20230101 --to 2024

Do we want to add a way to limit snapshot page size? The CDX server supports a pageSize parameter.

@JakeYallop JakeYallop changed the title Add smoke test Add smoke test that executes in CI May 18, 2024
@JakeYallop
Copy link
Owner Author

The executable supports passing --mockData since 6c2e257 - the smoke test should use --mockData as a first test, then try a second time making a real request (to test the actual code path that will normally be used).

@JakeYallop
Copy link
Owner Author

JakeYallop commented May 24, 2024

Is there a way we fake it so that although our code makes a real request using the real HttpClientHandler, we still return mock data from somewhere else? Not actually hitting the wayback machine servers for testing would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant