-
Notifications
You must be signed in to change notification settings - Fork 27
Mark tasks as done rather than deleting them? #25
Comments
@Jizzu Have you guys started working on this feature? I picked up your project as it was interesting and I'm exercising my kotlin/android jetpack features. I have a partially completed code in the below branch. https://github.com/subbramanil/SimpleToDo/tree/feature/mark_tasks_as_done It's still Work in Progress. I ran into an issue where the tasks are not inserted into the table. So I'm guessing I may have missed out something. I may spend some more time over the weekend to see if I can fix it. Also, this feature requires changes to the app that needs more information. So I don't know if you guys had thought about it. If you have, please share. I will see if I can contribute more. |
Hi, @subbramanil ! Thanks for your interest in this project :) I have not started this feature yet, but if you want, feel free to contribute to the project. PS: It also seems to me that for the status of the task it's better to use Boolean, not Int :) |
Hi @Jizzu I applied your changes, and it makes more sense. And I also updated the task status from Int to Boolean. Guess, I was equating SQLite data types to Room. I don't think SQLite supported 'Boolean' datatype directly, used to support through integer 0/1. |
Hi @Jizzu, Have you thought about how to handle completed tasks? Show the completed tasks in a separate screen would be the simplest. But I wanted to know if you had thought about any other design. |
Hi @Jizzu I hope that you are doing great. It's been a while since my last message. As I was cleaning up my works in 2019, I noticed that this is pending. So I spent some time and added the feature. Without a clear answer to my earlier questions, I took some liberty to design the feature on my own. Below are the changes I made and the design considerations.
Swipe Left to Right --> Complete the task With having a screen to see the completed tasks, I felt it would be better if I keep the behavior of swiping from Left to Right action similar to the behavior of the checkbox.
In addition,
I have tried to provide enough information in the commit messages. Overall I feel happy about completing the feature, but I may have overstepped my boundaries as a contributor. 😝 I am submitting a PR pretty soon. |
Maybe Im the only one. But would it be possible to add that right sweep marks the task as done and left sweep deletes it?
I usually check before I go to bed (hence why I might be the only person in the world wanting this) what I managed to finish during the day and plan for tomorrow by organising my tasks in the order I need to tackle them.
I would also love to see different lists and maybe a bit smaller font. But once again just personal opinons! Love the app and I'm looking forward to the 1.5 release! :)
The text was updated successfully, but these errors were encountered: