Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight color in 0.0.8 version #20

Open
tuutti opened this issue Oct 8, 2023 · 1 comment
Open

Highlight color in 0.0.8 version #20

tuutti opened this issue Oct 8, 2023 · 1 comment

Comments

@tuutti
Copy link
Contributor

tuutti commented Oct 8, 2023

The default highlight color was changed from #2a2837 to #b25e9e in #18 and I'm wondering if this was an intentional change since it makes the selection almost unreadable with certain languages.

Before

image

image

After

image

image
@dangtrivan15
Copy link
Contributor

dangtrivan15 commented Oct 25, 2023 •
edited
Loading

it is an intentional change of mine, as the original selection color was too similar to the background it was almost impossible to see the selected area boundaries. It might be of personal preference, so if needed, please try to open another PR, but please chose one other than the original.
I am actually a contributor, so I don't have permission to revert this as per your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tuutti @dangtrivan15