Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support different calendars #13

Closed
Jamalianpour opened this issue Jun 4, 2020 · 3 comments
Closed

support different calendars #13

Jamalianpour opened this issue Jun 4, 2020 · 3 comments
Assignees
Labels
C: Timetable Component: The actual timetable package T: Feature Type: :tada: New Features

Comments

@Jamalianpour
Copy link

hello,
how can I use persian calendar and date on this plugin?

@JonasWanke
Copy link
Owner

Thanks for filing this issue! Currently, timetable only supports the gregorian calendar. As it's based on time_machine (which also supports three variants of the persian calendar), adding support for other calendar systems should be relatively easy.

I can try implementing it starting next week, though I don't know how long I'll need for it.

@JonasWanke JonasWanke added C: Timetable Component: The actual timetable package T: Feature Type: :tada: New Features labels Jun 5, 2020
@Jamalianpour
Copy link
Author

thank you.
I will wait for it.

@JonasWanke
Copy link
Owner

Because time_machine is not maintained very actively and still hasn't published a null-safe version to pub.dev, I dropped the dependency on it as part of the big refactor/rewrite (issue: #17, PR: #69). Instead, Timetable now uses Dart's built-in DateTime. Unfortunately, this also means that supporting other calendars is now out of scope as Dart doesn't support them either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Timetable Component: The actual timetable package T: Feature Type: :tada: New Features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants