Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null-safety #59

Open
TatsuUkraine opened this issue Nov 22, 2020 · 7 comments
Open

Migrate to null-safety #59

TatsuUkraine opened this issue Nov 22, 2020 · 7 comments
Assignees
Labels
T: Feature Type: :tada: New Features

Comments

@TatsuUkraine
Copy link
Contributor

Everything is in title)

@TatsuUkraine TatsuUkraine added the T: Feature Type: :tada: New Features label Nov 22, 2020
@JonasWanke
Copy link
Owner

JonasWanke commented Dec 3, 2020

Migration to null-safety is currently blocked by the following (direct & transitive) dependencies not supporting null safety yet:

@IoanaAlexandru
Copy link

@JonasWanke would it be possible to unsound null safety to do a partial migration, I wonder?

@JonasWanke
Copy link
Owner

@IoanaAlexandru As crypto has published a null-safe version two days ago (unblocking dartx) and there's an open PR for time_machine, I'd rather wait for a few more days, hoping we'll be unblocked very soon.

@vendelin8
Copy link

dartx seems to be done
black_hole_flutter's PR is closed too
time_machine seems to be abandoned

@JonasWanke
Copy link
Owner

Sorry for the delay and for not keeping this up-to-date. I've recently started the rewrite originally proposed in #17, and as part of this rewrite, also migrated to null-safety and dropped time_machine and dartx dependencies (which wasn't migrated at the time). This rewrite isn't done yet, but I've already managed to overcome the major blockers (visible as layout overflows in the old app).

@JonasWanke JonasWanke self-assigned this Mar 5, 2021
@mcagrigoktas
Copy link

Hi. Does the work continue? Is there anything I can help with

@JonasWanke
Copy link
Owner

The work continues, but, unfortunately, quite slowly due to time constraints. I've posted an update here: #17 (comment). I'll try to get the API stable and release a new version very soon. After that, contributions are very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Feature Type: :tada: New Features
Projects
None yet
Development

No branches or pull requests

5 participants