Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Game IDs do not appear to be working as intended #60

Open
freakalope opened this issue Jun 22, 2024 · 4 comments
Open

Custom Game IDs do not appear to be working as intended #60

freakalope opened this issue Jun 22, 2024 · 4 comments

Comments

@freakalope
Copy link

freakalope commented Jun 22, 2024

When setting up Custom Game IDs with Discord Developer Portal, the IDs don't appear to be read correctly from the customGameIDs.json file. I've provided how I've formatted my file below.

{
"Team Fortress 2 Classic": 1253954090245947415,
"Open Fortress": 1253959551682875465
}

This just has to be in the folder when running installer.sh, correct? I ran the installer again to be sure, but this is part of the error that comes up when the game is open:

[Jun 21 2024 - 23:55:44] found game Team Fortress 2 Classic played by Freakalope
[Jun 21 2024 - 23:55:45] could not find the steam app ID for Team Fortress 2 Classic
[Jun 21 2024 - 23:55:45] game changed, updating to 'Team Fortress 2 Classic'
[Jun 21 2024 - 23:55:45] fetching the Discord game ID for Team Fortress 2 Classic
[Jun 21 2024 - 23:55:45] could not find the discord game ID for Team Fortress 2 Classic, defaulting to well, the default game ID

I can confirm that if I set the default Discord Application ID in the config.json to "1253954090245947415", then steam-presence displays it correctly but duplicated, as it is just replacing "a game on steam" with "Team Fortress 2 Classic". This leads me to believe that my application ID is being read correctly in the config.json, but not customGameIDs.json.

If this is not functioning as intended or I am doing something wrong, please let me know.

@JustTemmie
Copy link
Owner

sorry for the super late reply, but if you're still stuck on this and want it fixed - it seems like steam-presence just isn't reading the json file at all, it's supposed to go into the data folder, so steam-presence/data/customGameIDs.json

unsure if that's your problem, but it might be

@BubbyNX
Copy link

BubbyNX commented Aug 26, 2024

I tried adding a custom game ID to the .json file as well (there actually appears to be one both in the steam-presence folder and in the steam-presence/data folder) without any luck (it reverts to the 'a game on steam' default).

How does the service match the custom ID to the game? I did ensure that the name of the game I used matched exactly as it appears in my Steam library.

Thanks for any insight you might be able to provide! Love using this program so far!!

@JustTemmie
Copy link
Owner

the program opens data/customGameIDs.json, loops thru the json file and adds the "key" or "name" to a list, it strips "®, ©, ™, and ℠" from the names and makes them all lowercase - there shouldn't be any problem if you've added them to the right file but it might struggle with non-latin characters

would you mind posting the json file in a comment i can take a look at it and may figure something out?

@BubbyNX
Copy link

BubbyNX commented Aug 27, 2024

{ "The Elder Scrolls IV: Oblivion": 1277761296674197595 }

It's just the one game I have there so far. I noted the semi-colon in the title and tried to remove that, then ran the install script again, since you mentioned non-latin characters as a potential problem. That Application ID is one that I created. Should I expect any sort of output from running the installer.sh that would mention that the .json was parsed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants