Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated test for correct pixel transfer functions #68

Open
lexaknyazev opened this issue Feb 15, 2021 · 4 comments
Open

Dedicated test for correct pixel transfer functions #68

lexaknyazev opened this issue Feb 15, 2021 · 4 comments

Comments

@lexaknyazev
Copy link
Member

lexaknyazev commented Feb 15, 2021

As of today, only four glTF color textures use sRGB encoding:

  • emissiveTexture
  • pbrMetallicRoughness.baseColorTexture
  • KHR_materials_pbrSpecularGlossiness.specularGlossinessTexture
  • KHR_materials_sheen.sheenColorTexture

All other textures are sampled linearly. We need dedicated test models that would highlight potential implementation errors in that area.

It's important to note, that working with linear 8-bit values in DCC tools could be quite challenging as some editors may misrepresent such content on screen and show misleading color-picker values.

@donmccurdy
Copy link

If we create test assets for these cases, I would prefer to use KHR_materials_specular (KhronosGroup/glTF#1719) over KHR_materials_pbrSpecularGlossiness. Fine to have both, too, but the emphasis will be more on the first moving forward.

@emackey
Copy link
Member

emackey commented Jan 6, 2022

Is this resolved now?

@lexaknyazev
Copy link
Member Author

I'd prefer to keep this open until we have similar tests for:

  • KHR_materials_pbrSpecularGlossiness.diffuseTexture
  • KHR_materials_pbrSpecularGlossiness.specularGlossinessTexture
  • KHR_materials_sheen.sheenColorTexture
  • KHR_materials_specular.specularColorTexture

Although the SpecGloss is deprecated, Sample-Viewer had a bug with it and the sheen color: KhronosGroup/glTF-Sample-Viewer#295.

@DRx3D
Copy link
Contributor

DRx3D commented Nov 14, 2023

This issue has been opened for almost 3 years. Since the repo has moved and there is a request to keep it open until certain things are done, should this be transferred to Sample-Assets? If there is no response, the issue will be transferred to Sample Assets by 17 Nov.

@DRx3D DRx3D transferred this issue from KhronosGroup/glTF-Sample-Models Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants