Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify the multi language atomicdex code block's syntax is correct in all the supported languages #21

Open
gcharang opened this issue May 5, 2023 · 2 comments
Labels
enhancement New feature or request P0 Critical issue that needs to be fixed

Comments

@gcharang
Copy link
Collaborator

gcharang commented May 5, 2023

Add windows terminal support

@gcharang gcharang added enhancement New feature or request P0 Critical issue that needs to be fixed labels May 5, 2023
@smk762
Copy link
Contributor

smk762 commented May 11, 2023

Tested bash on linux, and got a userpass error.

This is because "userpass": "$userpass" should actually be "userpass": "'$userpass'"

Looking at the other examples, the userpass variable does not change as required for other languages. E.g. in python, "${userpass}" would not return a variable value, it would return the same text.

So for python and likely most other langs we'll need to:

  • declare a userpass variable (as const / string where type is required)
  • either source this from an environment variable (e.g. in py with userpass = os.getenv("USERPASS")) or as a generic YOUR_RPC_PASSWORD_HERE
  • substitute $userpass within the source request body with the declared variable.

@smk762
Copy link
Contributor

smk762 commented Jun 2, 2023

Ideally, this can be one via CI/CD. We just need to test the output for each lang variation in codeblocks using one of the playground nodes for some simple methods not using auth, but if using an mm2 image on the runner instead would allow for greater coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 Critical issue that needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants