Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Fail gracefully if coins file is invalid. #2036

Open
smk762 opened this issue Oct 31, 2022 · 0 comments
Open

[FR]: Fail gracefully if coins file is invalid. #2036

smk762 opened this issue Oct 31, 2022 · 0 comments
Labels
backend impact_ux next iteration to not forget to include it P2 Time permissive

Comments

@smk762
Copy link
Collaborator

smk762 commented Oct 31, 2022

related: #2035

Is your feature request related to a problem? Please describe.
Currently if coins file is corrupt or has unexpected structure, app will fail to launch.

Describe your solution
We should be able to detect this, and if there is an issue, download the latest pinned coins data from the coins repo.

Describe alternatives you've considered
Alternatively we can output console logs and a "login failed - coins file invalid" modal which allows user to click button to reset coins.

Additional context
This happens sometimes during testing when we switch branches using different coins repo files which may include new fields for new methods or integrations.

@ghost ghost self-assigned this Nov 2, 2022
@ghost ghost added the next iteration to not forget to include it label Nov 2, 2022
@smk762 smk762 added 0.5.8 backend impact_ux and removed next iteration to not forget to include it labels Nov 18, 2022
@smk762 smk762 added P2 Time permissive next iteration to not forget to include it and removed 0.5.8 labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend impact_ux next iteration to not forget to include it P2 Time permissive
Projects
None yet
Development

No branches or pull requests

1 participant