You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
this is just for discussion, not a real bug or issue.
Is the use of a "internal" package needed/useful? I find it unnecessarily complicated to contribute, for every change I have to fork, pull fork, change package import path to my user, make changes, change package import back, push. Otherwise I get an error when trying to run the tests:
binaryplease➜github.com/binaryplease/numgo(master)» go test .
package github.com/binaryplease/numgo
imports github.com/Kunde21/numgo/internal: use of internal package not allowed
This might be a stupid mistake as I'm pretty new to go. Is there a common workaround for this rather than changing the import path in the code forth and back all the time? I must admit I don't really understand the code in that folder very well though.
The text was updated successfully, but these errors were encountered:
The internal package is more for organization and cleanliness than functionality. It's all of the assembly code for vector operations specific to numgo. Since assembly isn't very user-friendly, I thought it best to keep it separate. I need to go through and put each asm function in its own file, as well.
For development, it's much easier to add your fork's remote to the original clone than juggle different copies:
go get github.com/Kunde21/numgo
cd $GOPATH/src/github.com/Kunde21/numgo
git remote add <RemoteName> [email protected]:binaryplease/numgo
Then, the only change to your workflow is specifying the remote in push/pull commands.
Hi,
this is just for discussion, not a real bug or issue.
Is the use of a "internal" package needed/useful? I find it unnecessarily complicated to contribute, for every change I have to fork, pull fork, change package import path to my user, make changes, change package import back, push. Otherwise I get an error when trying to run the tests:
This might be a stupid mistake as I'm pretty new to go. Is there a common workaround for this rather than changing the import path in the code forth and back all the time? I must admit I don't really understand the code in that folder very well though.
The text was updated successfully, but these errors were encountered: