New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only clone readonly patches in pc_patch_rotate_quaternion #39

Open

mbredif opened this issue Jan 31, 2017 · 0 comments

Labels

Collaborator

mbredif commented Jan 31, 2017

The cloning of the uncompressed pc_patch is currently done unconditionally in https://github.com/LI3DS/pointcloud/blob/dev/lib/pc_patch.c#L683-L688
This could be performed only when the patch is readonly, taking care of freeing the returned patch only if it differs from the input patch at https://github.com/LI3DS/pointcloud/blob/dev/pgsql/pc_editor.c#L63

mbredif mentioned this issue

Add PC_RotateQuaternion #29

Merged

mbredif added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment