Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper slider rendering #1

Open
LeaPhant opened this issue Jul 7, 2019 · 4 comments
Open

Add proper slider rendering #1

LeaPhant opened this issue Jul 7, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@LeaPhant
Copy link
Owner

LeaPhant commented Jul 7, 2019

Currently the slider rendering lacks catmull sliders and bezier sliders are poorly implemented. Slider repeats aren't implemented visually either. I need help for this as I'm really bad at math/rendering so feel free to PR.

Here are references from the osu!lazer codebase:

ppy/osu/osu.Game/Rulesets/Objects/SliderPath.cs
ppy/osu-framework/osu.Framework/MathUtils/PathApproximator.cs

@LeaPhant LeaPhant added enhancement New feature or request help wanted Extra attention is needed labels Jul 7, 2019
@LeaPhant
Copy link
Owner Author

Update on this: I added catmull sliders and circular arc sliders, bezier sliders could still be optimized but it's fine for now. Also I finally got slider point interpolation so every point on a slider track always the same distance, this prevents any sudden velocity changes and should result in always smooth linear movement of the slider ball (this is huge). Now that slider tracks are cleaned up slider repeats are next.

@LeaPhant
Copy link
Owner Author

Update: Slider repeats have been added, slider ticks are mostly done but I still have to find the algorithm which osu uses to decide which slider ticks to dismiss. Also slider velocity is still buggy and some sliders are too slow and therefore too long in time, but this is a fix to do in my osu-parser fork.

@LeaPhant
Copy link
Owner Author

Slider velocity is finally fixed in the osu-parser fork, slider length should be accurate now.

@LeaPhant
Copy link
Owner Author

Update: Slider ticks are finally correct and with that I'm pretty sure sliders are basically done. Now only minor changes like performance improvements or adding a gradient to slider bodies are left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant