-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and warn on installation time, if an old pycrypto
package is installed
#477
Comments
While the package metadata specification documents fields for that purpose, they are currently ignored by pip, if I'm not mistaken (see pypa/pip#4625). Nonetheless I think those fields should be set by Pycryptodome (in variant using the Crypto namespace). For installations from sources, a check in the setup.py can to it - but as installations from wheels get more common, those would get ignored there. If install-time checks are not possible, what about checking that during import-time, so it can be at least diagnosted easily? |
Yes, that would be a start. My humble guess, those fields will get more attention over time, and this project is a nice example for their usefulness (if handled correctly).
Yes, sure.
I'm pretty sure, that Helder won't like that idea much and I don't either, because it penalizes the common usage for a historical artefact. If at all, the lifetime of such a check should be limited, and we could use the deprecation fw for it? Helder? |
This is possible in setup.py:
I see no harm in a notification during installation. The person who did this intentionally will not care. The person who was unaware the |
Yes, that would be a start.
Yes, sure.
I'm pretty sure, that Helder won't like this idea very much and neither do I (FWIW) because it penalizes general use for a historical artifact. The good news is: there has been some progress in this regard recently: pip 20.3. |
Hi,
since a regular pattern of issues with
pycryptodome
seems to be an existingpycrypto
package installation in this setup, would it be possible to warn the user about this fact, or even fail the installation?I'm more active on the packaging front, where we typically solve this with a conflict/replacement.
Not sure how this is done best for pip and friends.
The text was updated successfully, but these errors were encountered: