Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block has light mode color for custom themes #2526

Open
4 tasks done
samifinge opened this issue Jun 10, 2024 · 1 comment
Open
4 tasks done

Code block has light mode color for custom themes #2526

samifinge opened this issue Jun 10, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@samifinge
Copy link

samifinge commented Jun 10, 2024

Requirements

  • This is a bug report, and if not, please post to https://lemmy.ml/c/lemmy_support instead.
  • Please check to see if this issue already exists.
  • It's a single bug. Do not report multiple bugs in one issue.
  • It's a frontend issue, not a backend issue; Otherwise please create an issue on the backend repo instead.

Summary

Text formatted as a code block has the white color scheme when using custom themes added into /lemmy-ui/extra_themes/

This occurs even if that custom themes just contains the same content as the default dark theme of darkly.css with no additional changes. Occurs in sidebar, posts and comments. Occurs regardless of browser/system's dark mode setting (separate issue mentioned here #2405).

darkcode

Steps to Reproduce

  1. Make a copy of darkly.css and rename it to something else
  2. Place it in the /lemmy-ui/extra_themes/ folder where custom themes go
  3. Navigate to account settings (ctrl+F5 for newly added file to appear)
  4. Select the new theme
  5. Make a comment containing code block formatting
  6. Observe background color of code block

Technical Details

Firefox on Linux and Android

Lemmy Instance Version

0.19.4

Lemmy Instance URL

https://lemmy.zip/c/[email protected]

@samifinge samifinge added the bug Something isn't working label Jun 10, 2024
@dessalines
Copy link
Member

The code-theming doesn't seem to work for custom themes. We'd need to add something to it that possibly checks the name of the theme, and makes sure it includes text like dark, to be able to set it correctly.

@dessalines dessalines added this to the 0.19.5 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants