Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Avoid re-deploying existing contracts from GH action #115

Open
bgins opened this issue May 23, 2024 · 0 comments
Open

[core] Avoid re-deploying existing contracts from GH action #115

bgins opened this issue May 23, 2024 · 0 comments
Assignees

Comments

@bgins
Copy link
Collaborator

bgins commented May 23, 2024

With the changes in #114, we deploy contracts to DevNet when we make changes to main. Contracts are blindly re-deployed, which is fine in testing environments but to be avoided when real money is involved.

Let's add a check to avoid re-deploying contracts. One possible approach would be to compile the contracts on the previous commit and then re-compile on the current commit. This may be enough to prevent hardhat from re-deploying, but it needs more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants