Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt formatOnSave changes #30

Closed
jrieken opened this issue Oct 18, 2016 · 2 comments
Closed

Adopt formatOnSave changes #30

jrieken opened this issue Oct 18, 2016 · 2 comments

Comments

@jrieken
Copy link
Contributor

jrieken commented Oct 18, 2016

Since VS Code now has the editor.formatOnSave-setting and the onWillSaveTextDocument-event, this code should be revisited. I'd recommend to remove it and to rely on the built-in formatOnSave feature or to use the new event. Both will prevent unnecessary fs-operations and reduce the risk for endless write-event-write loops.

See https://code.visualstudio.com/updates#_format-on-save, microsoft/vscode#12449, and microsoft/vscode#239 for more details

@Lonefy
Copy link
Owner

Lonefy commented Nov 24, 2016

Done

@Lonefy Lonefy closed this as completed Nov 24, 2016
@jrieken
Copy link
Contributor Author

jrieken commented Nov 24, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants