Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave performance mean_annual_energy_production_matrix has no test & is incompatible with example #339

Open
ssolson opened this issue Jul 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working wave module

Comments

@ssolson
Copy link
Contributor

ssolson commented Jul 3, 2024

In the wave_example.ipynb Input box [15] calls:

# Calcaulte maep from matrix
maep_matrix = wave.performance.mean_annual_energy_production_matrix(
    LM_mean, JM, LM_freq
)

In MHKiT v0.8.1 this will fail because mean_annual_energy_production_matrix is not setup to handle 2D DataFrames.
Additionally the check:

    if not np.abs(frequency.sum() - 1) < 1e-6:
        raise ValueError("Frequency components must sum to one.")

was added but does not work for this LM_freq matrix provided.

@akeeste could you add a test for this function and determine why the example LM_freq does not pass this check which was previously commented out.

#assert frequency.sum().sum() == 1

For #330 I will calculate manually and leave the MHKiT function call commented out.

@ssolson ssolson added bug Something isn't working wave module labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wave module
Projects
None yet
Development

No branches or pull requests

2 participants