Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amp client warning for pipeline method #19

Open
kelunik opened this issue Nov 6, 2021 · 2 comments
Open

Amp client warning for pipeline method #19

kelunik opened this issue Nov 6, 2021 · 2 comments
Labels
question Further information is requested

Comments

@kelunik
Copy link

kelunik commented Nov 6, 2021

Hey @MacFJA,

It's great to see support for amphp/redis built-in! Could you tell me what the notice in

&& trigger_error('Warning, \\Amp\\Redis\\Redis don\'t use a real Redis Pipeline', E_USER_NOTICE);
is supposed to mean?

@MacFJA
Copy link
Owner

MacFJA commented Nov 7, 2021

It's just that, AFAIK, there is not pipeline in Amp\Redis, so each command need to be send one by one, and are also executed one by one.

Where with a Redis pipeline:

  • all commands are sent to the server in one go
  • the server execute all commands
  • the server send one message containing all commands response.

With pipeline only one network request is made instead of one per command.

@kelunik
Copy link
Author

kelunik commented Nov 7, 2021

While amphp/redis uses separate write calls, pipelining is more about avoiding the RTT cost and it's totally supported by amphp/redis. The client won't wait for a server response before sending the next command. It uses pipelining by default.

@MacFJA MacFJA added the question Further information is requested label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants