Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning #62

Open
inpresif opened this issue Feb 21, 2023 · 5 comments
Open

Deprecation Warning #62

inpresif opened this issue Feb 21, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@inpresif
Copy link

inpresif commented Feb 21, 2023

Deprecated: Return type of MacFJA\RediSearch\Redis\Response\PaginatedResponse::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/macfja/redisearch/src/Redis/Response/PaginatedResponse.php on line 69

Deprecated: Return type of MacFJA\RediSearch\Redis\Response\PaginatedResponse::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/macfja/redisearch/src/Redis/Response/PaginatedResponse.php on line 104

Deprecated: Return type of MacFJA\RediSearch\Redis\Response\PaginatedResponse::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/macfja/redisearch/src/Redis/Response/PaginatedResponse.php on line 113

Deprecated: Return type of MacFJA\RediSearch\Redis\Response\PaginatedResponse::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/macfja/redisearch/src/Redis/Response/PaginatedResponse.php on line 136

HTH.

@MacFJA MacFJA added the bug Something isn't working label Feb 21, 2023
@MacFJA
Copy link
Owner

MacFJA commented Feb 21, 2023

Which version of PHP are you running ?

@inpresif
Copy link
Author

inpresif commented Feb 21, 2023

PHP Version 8.1.12

@inpresif
Copy link
Author

inpresif commented Feb 21, 2023

If I add this (as per the error message suggestion for PHP8 annotation), the errors go away...
image

Disclaimer: this is my patchwork, no idea if this is how it's supposed to be.

EDIT: Actually, I did it differently for the other 3 warnings by setting the return type:
image

@jeitnier
Copy link

Any update for this issue?

@gspirov
Copy link

gspirov commented Nov 6, 2023

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants