Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing property definitions from main specification text? #505

Open
rartino opened this issue Mar 22, 2024 · 2 comments
Open

Removing property definitions from main specification text? #505

rartino opened this issue Mar 22, 2024 · 2 comments
Labels
topic/property-definitions Property definitions framework

Comments

@rartino
Copy link
Contributor

rartino commented Mar 22, 2024

Now that #445 is merged, should we remove the property definitions from optimade.rst? It does not seem ideal that we have two set of "competing" definitions that could diverge going forward. Technically it is of course possible to insert a link in that part of the document to what we consider the single-point-of-truth of property definitions. However, that cannot be https://schemas.optimade.org/, since we need to be able to edit and reivew edits of the property definitions while we work.

In discussion with @ml-evs, one idea is that we actually check into the repo a generated markdown document for the "OPTIMADE Standard" from the property definition framework that as a single document contains all the property definitions in the same style as before.

(If we do this, we probably want to automatically validate that it is up to date as a commit hook)

@merkys
Copy link
Member

merkys commented May 13, 2024

I agree with the removal of actual property definitions. AFAIK, they do not contain anything which is not in #445, and there should be a single source of truth.

In discussion with @ml-evs, one idea is that we actually check into the repo a generated markdown document for the "OPTIMADE Standard" from the property definition framework that as a single document contains all the property definitions in the same style as before.

Sounds great - a human-readable description generated from the property definition framework makes a lot of sense.

@merkys merkys added the topic/property-definitions Property definitions framework label Jun 13, 2024
@merkys
Copy link
Member

merkys commented Jun 15, 2024

This is however blocked by the pending PRs introducing or modifying already existing properties. I would suggest resolving them first, or reworking them into PRs modifying property definitions directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/property-definitions Property definitions framework
Projects
None yet
Development

No branches or pull requests

2 participants