-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low contrast placeholders in JS template literals #48
Comments
Thanks for the feedback! I have the brightness set pretty high on the screens I use, but if I lower it I can see where you're coming from. Open your The brightness is a bit higher, but it's still the same basic hue. If you still need a little more contrast, I'm considering highlighting the background of the entire interpolation, not just the punctuation around it. Something like this (background Let me know what you think. Thanks, |
If you want to test out the background, put your cursor at the very beginning of Line 1270 and paste in {
"name": "String interpolation",
"scope": "meta.interpolation",
"background": "#FFBF0028",
}, |
I typically try to not reuse colors, especially from common scopes like keywords, so I think I'll keep #4040FF. However, there is an easy way to override scopes. Create {
"variables":
{
},
"globals":
{
},
"rules":
[
{
"name": "String interpolation delimiters",
"scope": "punctuation.section.interpolation",
"foreground": "#0B93FF"
},
]
} This way you can customize any scope you want (even adding new ones or deleting ones you don't like) and you don't have to worry about your changes being overridden by a new version. Thanks for the feedback, and please let me know if you need anything else! |
Hi, I find the dollar sign and curly braces in JS backtick string templates really hard to see unless I crank up the brightness on my monitor:
It doesn't look that bad when looking at this single instance of it, but in a page full of code and my eyes adjusted to the bright text all around it blends into the dark background and looks like whitespace.
Could you please make that dark blue lighter, or use a different, more contrasting color? Thanks.
The text was updated successfully, but these errors were encountered: