Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add Microsoft.Net.Test.Sdk as a dependency of net451 projects #190

Closed
NTaylorMullen opened this issue Nov 7, 2016 · 1 comment
Closed

Cannot add Microsoft.Net.Test.Sdk as a dependency of net451 projects #190

NTaylorMullen opened this issue Nov 7, 2016 · 1 comment
Assignees
@Faizan2304
Labels
enhancement exp: cli

Comments

@NTaylorMullen
Copy link
Member

Description

Microsoft.Net.Test.Sdk only supports net46 so it cannot be installed on net451 projects. ASP.NET has a min bar of net451 which makes running tests with this an issue.

Steps to reproduce

  • Create csproj that has target framework net451.
  • Add Microsoft.NET.Test.Sdk dependency.

Expected behavior

  • Restore completes successfully.

Actual behavior

  • Failed to restore

Environment

dotnet --info:

.NET Command Line Tools (1.0.0-preview3-004056)

Product Information:
 Version:            1.0.0-preview3-004056
 Commit SHA-1 hash:  ccc4968bc3

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64

Microsoft.NET.Test.Sdk version tested:
15.0.0-preview-20161024-02
@NTaylorMullen NTaylorMullen changed the title Cannot install Microsoft.Net.Test.Sdk on net451 Cannot add Microsoft.Net.Test.Sdk as a dependency for net451 projects Nov 7, 2016
@NTaylorMullen NTaylorMullen changed the title Cannot add Microsoft.Net.Test.Sdk as a dependency for net451 projects Cannot add Microsoft.Net.Test.Sdk as a dependency of net451 projects Nov 7, 2016
@NTaylorMullen NTaylorMullen mentioned this issue Nov 7, 2016
Closed
55 tasks
@codito
Copy link
Contributor

codito commented Nov 9, 2016

Microsoft.TestPlatform.TestHost must also support net451 targets.

codito added a commit that referenced this issue Nov 14, 2016
@codito
Fix for issue (#213) (#218)
b5cd5ab 
* Fix for issue (#213)

* Fix for bug #190

* Removing net46 since net45 will work for framework net46 and net45
@Faizan2304 Faizan2304 mentioned this issue Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Faizan2304 Faizan2304

Labels
enhancement exp: cli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codito @NTaylorMullen @Faizan2304