Add UWP testhost deps in meta package #1351
Conversation
| @@ -9,12 +9,24 @@ | |||
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | |||
| <licenseUrl>http://www.microsoft.com/web/webpi/eula/net_library_eula_enu.htm</licenseUrl> | |||
| <iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl> | |||
| <description>The MSbuild targets and properties for building the .Net core test projects.</description> | |||
| <description>The MSbuild targets and properties for building .NET Core, .NET Full framework and Universal Windows test projects.</description> | |||
There was a problem hiding this comment.
suggest: .NET test projects
| <dependency id="Microsoft.TestPlatform.TestHost" version="$Version$" /> | ||
| <dependency id="Microsoft.CodeCoverage" version="1.0.3" /> | ||
| <group targetFramework="uap10.0"> | ||
| <dependency id="System.ComponentModel.Primitives" version="4.1.0" /> |
There was a problem hiding this comment.
Why did we choose to not provide TestHost in section? CodeCoverage is not provided because it's not supported in UWP yet.
A comment in here may help our future selves :)
There was a problem hiding this comment.
please do not hardcode any version, set them as min version. You can look at objectmodel nuspec, there we specify min version of dependencies.
| <dependency id="System.ComponentModel.Primitives" version="4.1.0" /> | ||
| <dependency id="System.ComponentModel.TypeConverter" version="4.1.0" /> | ||
| <dependency id="System.Runtime.InteropServices.RuntimeInformation" version="4.0.0" /> | ||
| <dependency id="Newtonsoft.Json" version="9.0.1" /> |
There was a problem hiding this comment.
NewtonSoft.Json is also needed by TestHost. How do we keep versions in sync?
There was a problem hiding this comment.
Using JsonNetVersion from TestPlatform.Dependencies.props.
| @@ -12,6 +12,7 @@ | |||
| <iconUrl>http://go.microsoft.com/fwlink/?LinkID=288859</iconUrl> | |||
| <projectUrl>https://github.com/microsoft/vstest/</projectUrl> | |||
| <copyright>© Microsoft Corporation. All rights reserved.</copyright> | |||
| <tags>vstest visual-studio unittest testplatform mstest microsoft test</tags> | |||
There was a problem hiding this comment.
Searching for packages with test shows 1042 packages and testing lists 1045. While we're at it, maybe add testing as well. I wish it were easier to find and add tags from nuget ;)
|
@dotnet-bot please test Windows_NT / Debug Build |
Related issue
unit test app (universal windows) don't compile with Newtonsoft.Json