Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Category to Test Category mapping for ListFullyQualifiedTests #1369

Merged
merged 2 commits into from
Jan 9, 2018

Conversation

nigurr
Copy link

@nigurr nigurr commented Jan 9, 2018

Currently ListFullyQualifiedTests doesn't filter tests based on TestCategory for Nunit/Xunit adapters

@nigurr nigurr closed this Jan 9, 2018
@nigurr nigurr reopened this Jan 9, 2018
@nigurr nigurr closed this Jan 9, 2018
@nigurr nigurr reopened this Jan 9, 2018
@smadala
Copy link
Contributor

smadala commented Jan 9, 2018

@dotnet-bot please test Windows_NT / Release Build

1 similar comment
@nigurr
Copy link
Author

nigurr commented Jan 9, 2018

@dotnet-bot please test Windows_NT / Release Build

@@ -436,6 +437,13 @@ private static List<TestCase> GetFilteredTestCases(IEnumerable<TestCase> testCas
}
}

//This is hack for NUnit,Xunit to understand test category -> This method is called only for NUnit/Xunit
if (!traitDictionary.ContainsKey(TestCategory) && traitDictionary.ContainsKey(Category))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we test TIA with this change

@nigurr nigurr merged commit b6da462 into microsoft:master Jan 9, 2018
@nigurr nigurr deleted the users/nigurr/Fix_Nunit_Xunit_filter branch January 9, 2018 09:42
@JunielKatarn
Copy link

Can this switch ListFullyQualifiedTests be used without an output file?
I just want to print those to the command line.

@prawalagarwal
Copy link
Member

@JunielKatarn No this cannot be used without an output file. This flag was introduced for a very specific purpose and we needed it to output to a file back then.

@JunielKatarn
Copy link

@pranavkm How can I run tests in a binary, showing their fully qualified name?
Some namespaces/test classes may end up with colliding names, which makes reading the test output confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants