Cancellation timing issue fix. #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has been started is being ignored. We have the right plumbing in place but just seem to have missed initializing a var. Put that in place. All interface changes are internal only.
singhsarab
changed the title
|
If the cancel request is coming before run request, then is it possible that IDE is doing something wrong in initiating these request? |
smadala
reviewed
Jan 31, 2018
| { | ||
| if (this.activeTestRun == null) | ||
| { | ||
| var testRunCompleteEventArgs = new TestRunCompleteEventArgs(null, true, false, null, null, TimeSpan.Zero); | ||
| this.testRunEventsHandler.HandleTestRunComplete(testRunCompleteEventArgs, null, null, null); | ||
| testRunEventsHandler.HandleTestRunComplete(testRunCompleteEventArgs, null, null, null); |
There was a problem hiding this comment.
Who was handling NRE? Why there is no report to vstest.console/crash?
singhsarab
approved these changes
Jan 31, 2018
smadala
approved these changes
Jan 31, 2018
There was a problem hiding this comment.
Looks like this fixes the issue introduced in 15.6 but not the customer issue. @singhsarab will confirm it.
singhsarab
pushed a commit
to singhsarab/vstest
that referenced
this pull request
Feb 19, 2018
* Fix for a timing issue where a cancel request before test run request has been started is being ignored. We have the right plumbing in place but just seem to have missed initializing a var. Put that in place. All interface changes are internal only.
singhsarab
added a commit
that referenced
this pull request
Feb 19, 2018
* Fix for a timing issue where a cancel request before test run request has been started is being ignored. We have the right plumbing in place but just seem to have missed initializing a var. Put that in place. All interface changes are internal only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a timing issue where a cancel request before test run request has been started is being ignored.
We have the right plumbing in place but just seem to have missed initializing a var. Put that in place.
All interface changes are internal only.
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/559064
From testhost diag logs, this is the stack trace:
TpTrace Error: 0 : 17096, 8, 2018/01/30, 15:50:44.560, 1284210642450, testhost.x86.exe, LengthPrefixCommunicationChannel: MessageReceived: Exception occurred while calling handler of type Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.TestRequestHandler for MessageReceivedEventArgs: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Execution.ExecutionManager.Cancel()
at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.TestRequestHandler.OnMessageReceived(Object sender, MessageReceivedEventArgs messageReceivedArgs)
--- End of inner exception stack trace ---
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
at System.Delegate.DynamicInvokeImpl(Object[] args)
at Microsoft.VisualStudio.TestPlatform.Utilities.MulticastDelegateUtilities.SafeInvoke(Delegate delegates, Object sender, EventArgs args, String traceDisplayName)